Why do I need two subscriptions?

I have a Pro subscription, it’s over next year. I don’t remember if I bought if through iOS or Mac but the Mac version was not Pro. I try to “restore” from the Mac version but it said there was nothing to restore so I got the 7 day trial so I could use the Pro features I needed, but If I am paying for the yearly subscription do I need to purchase another subscription?

You only need one subscription if you are using the same Apple account on devices.

What you need is to ensure that the account is the same and iCloud sync is enabled so that the subscription details can be shared.